Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --zstd option (always using zstd) #1643

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Remove --zstd option (always using zstd) #1643

merged 1 commit into from
Jul 20, 2022

Conversation

kelson42
Copy link
Collaborator

Fixes #1642

@kelson42 kelson42 requested a review from kelvinhammond July 10, 2022 09:20
@kelson42
Copy link
Collaborator Author

@kelvinhammond BTW you can also remove the ability to compress using LZMA in openzim/libzim as well. See openzim/node-libzim#79

@codecov
Copy link

codecov bot commented Jul 10, 2022

Codecov Report

Merging #1643 (38ee8b7) into master (2448e2b) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1643      +/-   ##
==========================================
- Coverage   69.51%   69.50%   -0.02%     
==========================================
  Files          26       26              
  Lines        2401     2400       -1     
  Branches      469      468       -1     
==========================================
- Hits         1669     1668       -1     
  Misses        568      568              
  Partials      164      164              
Impacted Files Coverage Δ
src/mwoffliner.lib.ts 66.54% <ø> (+0.23%) ⬆️
src/parameterList.ts 100.00% <ø> (ø)
src/Downloader.ts 73.11% <0.00%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2448e2b...38ee8b7. Read the comment docs.

@kelvinhammond
Copy link
Collaborator

I'll look at this, this evening.

@kelson42
Copy link
Collaborator Author

@kelvinhammond Got any time to review? May I merge this small PR?

@kelson42 kelson42 merged commit f9e807a into master Jul 20, 2022
@kelson42 kelson42 deleted the always-zstd branch July 20, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support of LZMA in writting
2 participants