Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit handling of images processing and other fixes #2143

Merged
merged 2 commits into from
Feb 10, 2025

Download kind should be an enumarated type from TS perspective to avo…

0402980
Select commit
Loading
Failed to load commit list.
Merged

Revisit handling of images processing and other fixes #2143

Download kind should be an enumarated type from TS perspective to avo…
0402980
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 10, 2025 in 1s

75.63% (+0.33%) compared to 7c3857a

View this Pull Request on Codecov

75.63% (+0.33%) compared to 7c3857a

Details

Codecov Report

Attention: Patch coverage is 80.00000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 75.63%. Comparing base (7c3857a) to head (0402980).

Files with missing lines Patch % Lines
src/Downloader.ts 63.26% 17 Missing and 1 partial ⚠️
src/mwoffliner.lib.ts 60.00% 2 Missing ⚠️
src/renderers/abstract.renderer.ts 94.73% 2 Missing ⚠️
src/util/misc.ts 0.00% 2 Missing ⚠️
src/MediaWiki.ts 66.66% 1 Missing ⚠️
src/util/articleListMainPage.ts 0.00% 1 Missing ⚠️
src/util/saveArticles.ts 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2143      +/-   ##
==========================================
+ Coverage   75.29%   75.63%   +0.33%     
==========================================
  Files          41       41              
  Lines        3202     3213      +11     
  Branches      706      704       -2     
==========================================
+ Hits         2411     2430      +19     
+ Misses        674      666       -8     
  Partials      117      117              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.