Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eslint warnings #2147

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Fix eslint warnings #2147

merged 1 commit into from
Jan 30, 2025

Conversation

benoit74
Copy link
Contributor

Removing unused constant in mobile.renderer.test.ts, and commented the whole vikidia file.

Both were raising unneeded warnings:

image

@benoit74 benoit74 self-assigned this Jan 30, 2025
@benoit74 benoit74 requested a review from kelson42 January 30, 2025 11:58

Verified

This commit was signed with the committer’s verified signature.
luehm Alex Luehm
@benoit74 benoit74 force-pushed the fix_eslint_warnings branch from 0e6e52c to 55fd5a2 Compare January 30, 2025 13:14
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.45%. Comparing base (75cf0fe) to head (55fd5a2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2147      +/-   ##
==========================================
- Coverage   75.98%   75.45%   -0.54%     
==========================================
  Files          41       41              
  Lines        3202     3202              
  Branches      706      706              
==========================================
- Hits         2433     2416      -17     
- Misses        655      669      +14     
- Partials      114      117       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42 kelson42 merged commit 7c3857a into main Jan 30, 2025
6 checks passed
@kelson42 kelson42 deleted the fix_eslint_warnings branch January 30, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants