Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance handling of HTTP settings and TCP sockets #2149

Draft
wants to merge 3 commits into
base: faster_docker_build
Choose a base branch
from
Draft

Enhance handling of HTTP settings and TCP sockets #2149

wants to merge 3 commits into from

Conversation

benoit74
Copy link
Contributor

@benoit74 benoit74 commented Jan 30, 2025 •
edited
Loading

Fix #2137
Fix #2139
Fix #2141

Changes:

  • destroy S3 socket when we do not need the response because it is outdated
  • align S3 settings with Axios ones (keep-alive, no max sockets, insecure https, timeouts)
  • add a signal for connection timeout for all Axios calls
  • always use a pre-defined AxiosRequestConfig from downloader for all axios calls (even those outside the downloader)
  • mutualise settings of AxiosRequestConfig in a basicRequestOptions (keep-alive, timeouts, insecure HTTPs, login cookie)

Edit: to be merged to main only once #2148 is merged

@benoit74
Destroy S3 response to free sockets
ebf0af5
@benoit74
Align S3 http settings with axios ones
8ba3c86 
Deviation from SDK standard:
- requestTimeout is set
- rejectUnauthorized can be customized
- maxSockets is undefined / number of sockets is unlimited
@benoit74 benoit74 self-assigned this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@benoit74 benoit74

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@benoit74