Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix url escaping (#726) #998

Merged
merged 1 commit into from
Oct 19, 2019
Merged

🐛 fix url escaping (#726) #998

merged 1 commit into from
Oct 19, 2019

Conversation

ISNIT0
Copy link
Contributor

@ISNIT0 ISNIT0 commented Oct 15, 2019

Closes #726
Looks like there was a bug & a test was incorrect.

@ISNIT0 ISNIT0 requested a review from kelson42 October 15, 2019 15:26
@codecov
Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #998 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #998   +/-   ##
=======================================
  Coverage   63.48%   63.48%           
=======================================
  Files          20       20           
  Lines        1698     1698           
  Branches      345      345           
=======================================
  Hits         1078     1078           
  Misses        452      452           
  Partials      168      168
Impacted Files Coverage Δ
src/Dump.ts 36.63% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1e6d47...a469215. Read the comment docs.

@kelson42 kelson42 merged commit e8666d8 into master Oct 19, 2019
@kelson42 kelson42 deleted the ISNIT0/726 branch October 19, 2019 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Badly rewritten URLs in case of "/" in the article title
2 participants