-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove inline Javascript #152
Conversation
@pavel-karatsiuba ready to review (if then, please put me in reviewer)? Otherwise please rewrite the history, no merge in the feature branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems we still have inline javascript (it does not pass in Kiwix JS). I see at least:
<script id='ractive-template' type='text/html'>
on home page
This script was not dangerous for CSP. But I also moved it to a separated file. |
84b5e30
to
7551886
Compare
7357c76
to
018bcba
Compare
@Jaifroid We have removed all the inline JS, but this still does not load properly in Kiwix-JS. See https://www.dropbox.com/s/alfulridglnsxkv/phet_fr_2022-12.zim?dl=0. Another problem? |
018bcba
to
57446b9
Compare
@Jaifroid Actually it seems that my test was wrong (was testing with JQuery). Works fine. I will merge the PR and let me know if any other problem. |
Thank you, this helps with kiwix/kiwix-js#865. |
Javascript was moved from index.html to a separate file.
Fixes #134