Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mkdocs #215

Merged
merged 5 commits into from
Dec 12, 2024
Merged

Added mkdocs #215

merged 5 commits into from
Dec 12, 2024

Conversation

josephlewis42
Copy link
Contributor

Part of #92

This PR adds initial doc generation to python-scraperlib. You can see them locally by running hatch run docs:serve, screenshot below:

image

I tried to keep things pretty well documented because piecing together these plugins isn't entirely straightforward.

There are probably a few things to fix, but my goal is to have a good enough start here that a maintainer can start looking at getting these auto-published.

@benoit74
Copy link
Collaborator

Hi @josephlewis42, thank you very much for this PR, not easy to review on our side, we'll do our best next week

@benoit74
Copy link
Collaborator

benoit74 commented Dec 11, 2024

Wooo, one month already ... time fly too fast! I will review it tomorrow, very sorry for that delay, not our standard

@benoit74 benoit74 self-assigned this Dec 12, 2024
@benoit74 benoit74 self-requested a review December 12, 2024 08:20
Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good work @josephlewis42

I've fixed few things which were "important" to fix from my PoV.

There are other rough edges to polish (mainly our own docstrings which are far from perfect) but this can already be merged since it provides lots of value.

I will move on with the merge and setup readthedocs publishing.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5a002d2) to head (cb91ca2).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #215   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           38        38           
  Lines         2227      2227           
  Branches       426       426           
=========================================
  Hits          2227      2227           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 merged commit fc1967f into openzim:main Dec 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants