-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added mkdocs #215
Added mkdocs #215
Conversation
Hi @josephlewis42, thank you very much for this PR, not easy to review on our side, we'll do our best next week |
Wooo, one month already ... time fly too fast! I will review it tomorrow, very sorry for that delay, not our standard |
7ffe6fb
to
cb91ca2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good work @josephlewis42
I've fixed few things which were "important" to fix from my PoV.
There are other rough edges to polish (mainly our own docstrings which are far from perfect) but this can already be merged since it provides lots of value.
I will move on with the merge and setup readthedocs publishing.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 38 38
Lines 2227 2227
Branches 426 426
=========================================
Hits 2227 2227 ☔ View full report in Codecov by Sentry. |
Part of #92
This PR adds initial doc generation to
python-scraperlib
. You can see them locally by runninghatch run docs:serve
, screenshot below:I tried to keep things pretty well documented because piecing together these plugins isn't entirely straightforward.
There are probably a few things to fix, but my goal is to have a good enough start here that a maintainer can start looking at getting these auto-published.