Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in disable-metadata-checks arg in ted2zim-multi #202

Closed
dan-niles opened this issue May 22, 2024 · 0 comments · Fixed by #205
Closed

Typo in disable-metadata-checks arg in ted2zim-multi #202

dan-niles opened this issue May 22, 2024 · 0 comments · Fixed by #205
Labels
bug good first issue
Milestone
3.0.2

Comments

@dan-niles
Copy link
Contributor

There is a typo in the disable-metadata-checks arg in the ted2zim-multi mode in the following two lines:

ted/src/ted2zim/multi/scraper.py

Line 288 in effb3a8

args += ["--disable-metadatachecks"]

ted/src/ted2zim/multi/scraper.py

Line 320 in effb3a8

args += ["--disable-metadatachecks"]

It should be --disable-metadata-checks, as defined here.
@benoit74 benoit74 self-assigned this May 22, 2024
@benoit74 benoit74 added the bug label May 22, 2024
@benoit74 benoit74 removed their assignment May 22, 2024
@benoit74 benoit74 added this to the 3.1.0 milestone May 22, 2024
@benoit74 benoit74 modified the milestones: 3.1.0, 3.0.2 Jun 15, 2024
@benoit74 benoit74 mentioned this issue Jun 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
3.0.2
Development

Successfully merging a pull request may close this issue.

Upgrade dependencies and fix typo openzim/ted
2 participants
@benoit74 @dan-niles