Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies and fix typo #205

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Upgrade dependencies and fix typo #205

merged 4 commits into from
Jun 21, 2024

Conversation

benoit74
Copy link
Collaborator

Fix #204
Fix #202

Changes

  • Upgrade all dependencies, including zimscraperlib 3.4.0 which brings in the migration to VP9 instead of VP8
  • Adopt bootstrap v1.0.2 (fix codecov report generation)
  • Fix typo in input argument for playlist mode

@benoit74 benoit74 self-assigned this Jun 21, 2024
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 5.05%. Comparing base (e0ab3d5) to head (6614d4b).
Report is 20 commits behind head on main.

Files Patch % Lines
src/ted2zim/multi/scraper.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #205      +/-   ##
========================================
+ Coverage   0.00%   5.05%   +5.05%     
========================================
  Files          7       8       +1     
  Lines       1055    1088      +33     
  Branches     228     237       +9     
========================================
+ Hits           0      55      +55     
+ Misses      1055    1032      -23     
- Partials       0       1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 marked this pull request as ready for review June 21, 2024 12:37
@benoit74 benoit74 requested a review from rgaudin June 21, 2024 12:37
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ; S3 version uses the preset.VERSION flag so nothing to change !

@benoit74 benoit74 merged commit 3f5c14c into main Jun 21, 2024
7 checks passed
@benoit74 benoit74 deleted the scraperlib_3_4_0 branch June 21, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to scraperlib 3.4.0 and VP9 presets Typo in disable-metadata-checks arg in ted2zim-multi
2 participants