Python bootstrap #154
Python bootstrap #154
Conversation
benoit74
force-pushed
the
python_bootstrap
branch
2 times, most recently
from
54164cc to
bc1c332
Compare
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
benoit74
force-pushed
the
python_bootstrap
branch
from
bc1c332 to
8c46769
Compare
benoit74
force-pushed
the
python_bootstrap
branch
from
8c46769 to
c727a6e
Compare
src/ted2zim/scraper.py
Outdated
| ) | ||
| raise ValueError("Wrong topic(s) were supplied. No videos found") | ||
|
|
||
| def run(self): | ||
| logger.info( | ||
| f"Starting scraper with:\n" | ||
| f" langs: {', '.join(self.source_languages)}\n" | ||
| f" subtitles : {', '.join(self.subtitles_setting) if isinstance(self.subtitles_setting, list) else self.subtitles_setting}\n" | ||
| f" subtitles : { ', '.join(self.subtitles_setting) if isinstance(self.subtitles_setting, list) else self.subtitles_setting}\n" # noqa: E501 |
There was a problem hiding this comment.
Why a space at begining of expr in f-string?
There was a problem hiding this comment.
It was like that before I came ; looks like this is some sort of identations to make stuff more readable.
There was a problem hiding this comment.
Well It's unbalanced so it's incorrect anyway. Our convention is to not use spaces here (see line above) so I think it should be fixed.
There was a problem hiding this comment.
Oh, we weren't speaking about the same space ; this one is weird, you are right
I explained this in the issue + intended to add a link to explain this in pyproject.toml but it looks like I got interrupted
Yes, I want to do this in two steps. This is why there is two tickets now (since our discussion from Tuesday), one for the bootstrap (which will be closed by this PR) and another one to update scraperlib to 3.x once we have the new flag to not check metadata in multi mode. |
|
@rgaudin did you configured Trusted publishing for this repo as well? |
|
Oups, I forgot to push, this is why the CI is still all green 🤣 |
|
Commits pushed and CI all green, sorry for that |
|
I just realized that we should answer to openzim/overview#13 (comment) before merging this. |
|
I forgot to update README.md to use hatch + harmonize badges, that's done now. |
I did |
benoit74
force-pushed
the
python_bootstrap
branch
from
649353f to
0ac336a
Compare
Rationale
Fix #153
Changes