Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HTTP retries #198

Merged
merged 1 commit into from
May 14, 2024
Merged

Fix HTTP retries #198

merged 1 commit into from
May 14, 2024
+13 −12

Conversation

benoit74
Copy link
Collaborator

Rationale

Fix #162

Changes

  • the try/catch logic used to retry HTTP call was only taking care of bad HTTP status code, while indeed we are far more interested in retrying connection issues (timeout mostly, but also intermittent DNS issues, ...)

@benoit74 benoit74 self-assigned this May 14, 2024
@benoit74 benoit74 force-pushed the fix_http_retries branch from e4c5987 to 08ae56d Compare May 14, 2024 08:45
@benoit74 benoit74 marked this pull request as ready for review May 14, 2024 08:48
@benoit74 benoit74 requested a review from rgaudin May 14, 2024 08:48
rgaudin
rgaudin approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoit74
Retry HTTP calls on any error occuring during the request, not only b…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
b79554c 
…ad HTTP status code
@benoit74 benoit74 force-pushed the fix_http_retries branch from 08ae56d to b79554c Compare May 14, 2024 12:02
@benoit74 benoit74 merged commit 09b92b3 into main May 14, 2024
5 checks passed
@benoit74 benoit74 deleted the fix_http_retries branch May 14, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgaudin rgaudin

Assignees

@benoit74 benoit74

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TED recipe by topic fails with HTTP read timed out in extract_info_from_video_page
2 participants
@benoit74 @rgaudin