Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New UI: HTML page title should be the ZIM title #227

Closed
benoit74 opened this issue Jun 14, 2024 · 0 comments · Fixed by #250
Closed

New UI: HTML page title should be the ZIM title #227

benoit74 opened this issue Jun 14, 2024 · 0 comments · Fixed by #250
Assignees
Milestone

Comments

@benoit74
Copy link
Collaborator

The HTML page title is currently a constant "YouTube in a ZIM". This is displayed for instance in browser tabs.

This title should be "dynamically" aligned with the ZIM title (passed to the scraper CLI or computed dynamically).

The way the title is set is important, because ideally it should be available in the HTML when page loads because most (all?) readers use this HTML page title to render it somewhere in the UI but most (all?) do not respond to dynamic modification of the page title via JS code. But maybe this is just too complex and we should rather open issues in readers to support dynamic updates of the page titles. TbC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants