-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create homepage UI for channels in zimui
#225
Conversation
af102d3
to
b520bc1
Compare
b520bc1
to
af7201c
Compare
zimui
zimui
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A first general comment is: well done, from a code perspective, there is very little to say (only few inline comments).
I tried to build a ZIM with the UI inside and it is working (only discovered #226 and #227 but these are "details")
From a higher level perspective, I wonder if we should fine-tune a little bit the UI, it is quite visible that you've deviated from original design. I'm however not sure it is the right moment to do it, mostly because I'm not sure that your current design is worse than original one. I suggest that we keep the design as-is for now, and we then organize a session with designers once the whole UI is ready and with a real channel to discuss the details that need to be fixed and the ones we do not care about. We should open an issue about this, something like "Fine-tune UI visual details"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
This PR adds the homepage for the new Vue.js UI. The following things were done:
Tests.yml
workflow to run Cypress testsScreenshots:
![image](https://private-user-images.githubusercontent.com/56271899/339212119-3497e24e-443a-4359-8c15-936dfd572efc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2OTgyODcsIm5iZiI6MTczOTY5Nzk4NywicGF0aCI6Ii81NjI3MTg5OS8zMzkyMTIxMTktMzQ5N2UyNGUtNDQzYS00MzU5LThjMTUtOTM2ZGZkNTcyZWZjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDA5MjYyN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU2N2U0NTlkYjc1ZmE5MWVmMGY2NTRlYTM4Y2M3MDRmZDJkNTEwZGVjYTdkZjI3ZjAxOTAzYjAzNjRjMDNkM2QmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.VGfcks7YLZaATZg0Bq8dZ2x5S8pAFPnvBfVSX4hZYlU)
![image](https://private-user-images.githubusercontent.com/56271899/339212739-2e12b01f-044d-4339-9768-69784469f66c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2OTgyODcsIm5iZiI6MTczOTY5Nzk4NywicGF0aCI6Ii81NjI3MTg5OS8zMzkyMTI3MzktMmUxMmIwMWYtMDQ0ZC00MzM5LTk3NjgtNjk3ODQ0NjlmNjZjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDA5MjYyN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTIyMzJlYTE5YzJkMDM0MmMwNTkyNjk5NGEzMzIwNzk0ZGEyMzNjMTM0YThjYmRlMGQxMjIzNzRiZGZlNDdkODAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.zJUh7ouemCuR-edS-5TgCydbDTHUKDfp91Tp8VBi26g)
Closes #213
Closes #214
Closes #210