Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zimwriterfs create zim file with compressed illustration (wrong mimetype) #355

Closed
mgautierfr opened this issue Jun 21, 2023 · 0 comments · Fixed by #356
Closed

Zimwriterfs create zim file with compressed illustration (wrong mimetype) #355

mgautierfr opened this issue Jun 21, 2023 · 0 comments · Fixed by #356
Assignees
@mgautierfr
Labels
bug
Milestone
3.3.0

Comments

@mgautierfr
Copy link
Collaborator

Zimwriterfs add all metadata using addMetada (https://github.com/openzim/zim-tools/blob/main/src/zimwriterfs/zimwriterfs.cpp#L126). But the default mimetype in this case is text/plain;charset=utf-8 which is obviously wrong for illustration.
@mgautierfr mgautierfr added the bug label Jun 21, 2023
@mgautierfr mgautierfr self-assigned this Jun 21, 2023
mgautierfr added a commit that referenced this issue Jun 21, 2023
@mgautierfr
[zimwriterfs] Use the correct method to add the illustration to zim f…
1b39c5d 
…ile.

Fix #355
@mgautierfr mgautierfr mentioned this issue Jun 21, 2023
Merged
mgautierfr added a commit to kiwix/java-libkiwix that referenced this issue Jun 21, 2023
@mgautierfr
Update test zim file.
c7ac3a0 
zim files have been created using a recent version of zimwriterfs
(including the fix for openzim/zim-tools#355
@kelson42 kelson42 added this to the 3.3.0 milestone Jun 21, 2023
mgautierfr added a commit that referenced this issue Jul 28, 2023
@mgautierfr
[zimwriterfs] Use the correct method to add the illustration to zim f…
2d14520 
…ile.

Fix #355
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgautierfr mgautierfr

Labels
bug
Projects
None yet
Milestone
3.3.0
Development

Successfully merging a pull request may close this issue.

[zimwriterfs] Use the correct method to add the illustration to zim file. openzim/zim-tools
2 participants
@mgautierfr @kelson42