Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix json output #281

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Fix json output #281

merged 1 commit into from
Jan 13, 2022

Conversation

mgautierfr
Copy link
Collaborator

Use " instead of ' for strings.

Fix #278

Use " instead of ' for strings.

Fix #278
@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #281 (6515568) into master (d8279fd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #281   +/-   ##
=======================================
  Coverage   51.13%   51.13%           
=======================================
  Files          21       21           
  Lines        1936     1936           
  Branches     1146     1146           
=======================================
  Hits          990      990           
  Misses        944      944           
  Partials        2        2           
Impacted Files Coverage Δ
src/zimcheck/json_tools.cpp 95.91% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8279fd...6515568. Read the comment docs.

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks

@mgautierfr mgautierfr merged commit 3a9a989 into master Jan 13, 2022
@mgautierfr mgautierfr deleted the fix_json_log branch January 13, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zimcheck json output is invalid
3 participants