Finite task queue in zimcheck #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Need #307 corrected and merged before this one. |
Before adding blocking of the input end of the queue, it must be made explicit that the previous blocking pertained to the output end.
veloman-yunkan
force-pushed
the
zimcheck_finite_task_queue
branch
from
c5b2ab0 to
cbf318d
Compare
Codecov Report
@@ Coverage Diff @@
## zimcheck_protocol_relative_external_urls #309 +/- ##
============================================================================
+ Coverage 51.18% 51.25% +0.07%
============================================================================
Files 21 21
Lines 1944 1953 +9
Branches 1152 1154 +2
============================================================================
+ Hits 995 1001 +6
- Misses 947 950 +3
Partials 2 2
Continue to review full report at Codecov.
|
Base automatically changed from
zimcheck_protocol_relative_external_urls
to
master
July 5, 2022 14:12
mgautierfr
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #308
This PR was created on top of #307 in order to be able to test it on stackoverflow.com_en_all_2022-05.zim. #307 must be merged first.