deps: updates main versions notably zipkin #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry scribe got upset |
|
I think I'll switch the scribe test to use docker so the classpath isn't tangled with zipkin's |
Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
force-pushed
the
main-versions
branch
from
f8f6762 to
cebacd9
Compare
| .contains(Arrays.copyOfRange(LOTS_OF_SPANS, 0, 50)); | ||
| } | ||
|
|
||
| @Test public void sendsSpansExpectedMetrics() throws Exception { |
There was a problem hiding this comment.
I removed this as it was testing zipkin not zipkin-reporter.
| @@ -67,7 +67,8 @@ | |||
| <junit.version>4.13.2</junit.version> | |||
| <junit-jupiter.version>5.10.1</junit-jupiter.version> | |||
| <okhttp.version>3.14.9</okhttp.version> | |||
| <logback.version>1.4.14</logback.version> | |||
| <!-- use pre slf4j 2 version --> | |||
| <logback.version>1.2.13</logback.version> | |||
There was a problem hiding this comment.
reverted noticing logging didn't work
anuraaga
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes scribe tests to not share a dependency with zipkin, but it doesn't address #201, which breaks compatibility.