Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: updates to latest notably zipkin #221

Merged
merged 1 commit into from
Dec 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benchmarks/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@
<artifactId>kafka-junit</artifactId>
<!-- This version is tightly coupled to the version of kafka-clients being used.
https://github.com/charithe/kafka-junit -->
<version>4.1.10</version>
<version>4.2.10</version>
</dependency>
<dependency>
<groupId>junit</groupId>
Expand Down
2 changes: 1 addition & 1 deletion bom/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<properties>
<main.basedir>${project.basedir}/..</main.basedir>
<!-- use the same value in ../pom.xml -->
<zipkin.version>2.24.4</zipkin.version>
<zipkin.version>2.25.0</zipkin.version>
</properties>

<url>https://github.com/openzipkin/zipkin-reporter-java</url>
Expand Down
2 changes: 1 addition & 1 deletion brave/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
</dependency>
<dependency>
<groupId>io.zipkin.zipkin2</groupId>
<artifactId>zipkin-junit</artifactId>
<artifactId>zipkin-junit5</artifactId>
<version>${zipkin.version}</version>
<scope>test</scope>
</dependency>
Expand Down
20 changes: 10 additions & 10 deletions brave/src/test/java/zipkin2/reporter/brave/BasicUsageTest.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2016-2020 The OpenZipkin Authors
* Copyright 2016-2023 The OpenZipkin Authors
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
* in compliance with the License. You may obtain a copy of the License at
Expand All @@ -19,9 +19,9 @@
import brave.propagation.TraceContextOrSamplingFlags;
import java.util.ArrayList;
import java.util.List;
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import zipkin2.Span;

import static org.assertj.core.api.Assertions.assertThat;
Expand All @@ -33,7 +33,7 @@ abstract class BasicUsageTest<H extends ZipkinSpanHandler> {

abstract H zipkinSpanHandler(List<Span> spans);

@Before public void init() {
@BeforeEach void init() {
zipkinSpanHandler = zipkinSpanHandler(spans);
tracing = Tracing.newBuilder()
.localServiceName("Aa")
Expand All @@ -43,11 +43,11 @@ abstract class BasicUsageTest<H extends ZipkinSpanHandler> {
.build();
}

@After public void close() {
@AfterEach void close() {
tracing.close();
}

@Test public void reconfigure() {
@Test void reconfigure() {
tracing.close();
zipkinSpanHandler.close();

Expand All @@ -74,7 +74,7 @@ abstract class BasicUsageTest<H extends ZipkinSpanHandler> {
}

/** This mainly shows endpoints are taken from Brave, and error is back-filled. */
@Test public void basicSpan() {
@Test void basicSpan() {
TraceContext context = B3SingleFormat.parseB3SingleFormat(
"50d980fffa300f29-86154a4ba6e91385-1"
).context();
Expand Down Expand Up @@ -105,7 +105,7 @@ void triggerReport() {
}

/** This shows that in practice, we don't report when the user tells us not to! */
@Test public void abandonedSpan() {
@Test void abandonedSpan() {
TraceContext context = B3SingleFormat.parseB3SingleFormat(
"50d980fffa300f29-86154a4ba6e91385-1"
).context();
Expand All @@ -119,7 +119,7 @@ void triggerReport() {
assertThat(spans).isEmpty();
}

@Test public void unsampledSpan() {
@Test void unsampledSpan() {
brave.Span unsampledRemote =
tracing.tracer().nextSpan(TraceContextOrSamplingFlags.NOT_SAMPLED).name("test").start(1L);
assertThat(unsampledRemote.isNoop()).isTrue();
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2016-2020 The OpenZipkin Authors
* Copyright 2016-2023 The OpenZipkin Authors
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
* in compliance with the License. You may obtain a copy of the License at
Expand All @@ -16,12 +16,13 @@
import java.util.List;
import java.util.concurrent.TimeUnit;
import org.junit.Rule;
import org.junit.jupiter.api.extension.RegisterExtension;
import zipkin2.Span;
import zipkin2.junit.ZipkinRule;
import zipkin2.junit5.ZipkinExtension;
import zipkin2.reporter.okhttp3.OkHttpSender;

public class BasicUsageTest_Async extends BasicUsageTest<AsyncZipkinSpanHandler> {
@Rule public ZipkinRule zipkin = new ZipkinRule();
@RegisterExtension public ZipkinExtension zipkin = new ZipkinExtension();

OkHttpSender sender = OkHttpSender.create(zipkin.httpUrl() + "/api/v2/spans");

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ String bootstrapServer() {
// mostly waiting for https://github.com/testcontainers/testcontainers-java/issues/3537
static final class KafkaContainer extends GenericContainer<KafkaContainer> {
KafkaContainer() {
super(parse("ghcr.io/openzipkin/zipkin-kafka:2.24.4"));
super(parse("ghcr.io/openzipkin/zipkin-kafka:2.25.0"));
if ("true".equals(System.getProperty("docker.skip"))) {
throw new TestAbortedException("${docker.skip} == true");
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ Response get(String path) throws IOException {
// mostly waiting for https://github.com/testcontainers/testcontainers-java/issues/3537
static final class ZipkinContainer extends GenericContainer<ZipkinContainer> {
ZipkinContainer() {
super(parse("ghcr.io/openzipkin/zipkin:2.24.4"));
super(parse("ghcr.io/openzipkin/zipkin:2.25.0"));
if ("true".equals(System.getProperty("docker.skip"))) {
throw new TestAbortedException("${docker.skip} == true");
}
Expand Down
2 changes: 1 addition & 1 deletion metrics-micrometer/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<module.name>zipkin2.reporter.metrics.micrometer</module.name>

<main.basedir>${project.basedir}/..</main.basedir>
<micrometer.version>1.12.0</micrometer.version>
<micrometer.version>1.12.1</micrometer.version>
</properties>

<dependencies>
Expand Down
4 changes: 3 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,16 @@
<errorprone.version>2.23.0</errorprone.version>

<!-- use the same value in bom/pom.xml -->
<zipkin.version>2.24.4</zipkin.version>
<zipkin.version>2.25.0</zipkin.version>

<!-- Do not set this value in bom/pom.xml to avoid cyclic pinning -->
<brave.version>5.16.0</brave.version>

<junit.version>4.13.2</junit.version>
<junit-jupiter.version>5.10.1</junit-jupiter.version>
<!-- use pre-kotlin version -->
<okhttp.version>3.14.9</okhttp.version>
<okhttp5.version>5.0.0-alpha.11</okhttp5.version>
<!-- use pre slf4j 2 version -->
<logback.version>1.2.13</logback.version>
<testcontainers.version>1.19.3</testcontainers.version>
Expand Down