Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller Config Version Override #648

Closed
michaelquigley opened this issue Jun 11, 2024 · 0 comments
Closed

Controller Config Version Override #648

michaelquigley opened this issue Jun 11, 2024 · 0 comments
Assignees
Labels
enhancement Enhancement of an existing feature
Milestone

Comments

@michaelquigley
Copy link
Collaborator

We have a new controller configuration (v: 4) coming out to support the limits changes. The production team wants to come up with a config file version that will use combined syntax to run on both v0.4.30 and the new v0.4.31.

To support this, I'm going to add support for setting a ZROK_CTRL_CONFIG_VERSION environment variable that will override the version of the config found in the file. This will make a file containing v: 3 work on a v: 4 controller, and yet will still break when v: 5 comes out.

The presence of this environment variable on certain controller versions and the absence on others will allow for mixed version configurations when the syntax is amenable to that working.

@michaelquigley michaelquigley self-assigned this Jun 11, 2024
@michaelquigley michaelquigley added the enhancement Enhancement of an existing feature label Jun 11, 2024
@michaelquigley michaelquigley added this to the v0.4 milestone Jun 11, 2024
michaelquigley added a commit that referenced this issue Jun 12, 2024
@michaelquigley michaelquigley moved this from Development to Evaluating in zrok Development Roadmap Jun 12, 2024
@michaelquigley michaelquigley moved this from Evaluating to Done in zrok Development Roadmap Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of an existing feature
Projects
Development

No branches or pull requests

1 participant