Improved URL Parsing #222
Merged
Improved URL Parsing #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dovholuknf
reviewed
Feb 8, 2023
cmd/zrok/util.go
Outdated
| func parseUrl(in string) (string, error) { | ||
| // parse port-only urls | ||
| if iv, err := strconv.ParseInt(in, 10, 0); err == nil { | ||
| return fmt.Sprintf("http://127.0.0.1:%d", iv), nil |
There was a problem hiding this comment.
this should test for < 65535, no?
There was a problem hiding this comment.
i feel like it should tell me that it's inferred 'http'. for example if i zrok share 443, i would have inferred https
There was a problem hiding this comment.
I wouldn't expect it to infer HTTPS URL scheme if the arg is "443", but I would expect that if the arg was "https".
dovholuknf
approved these changes
Feb 8, 2023
qrkourier
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects this issue:
#211
And also supports URLs like:
9090-> http://127.0.0.1:9090localhost:9090-> http://127.0.0.1:9090https://localhost:9090-> https://localhost:9090Should align more closely with what users will likely expect.