Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete the zrok-access cookie if not oauth #524

Merged
merged 6 commits into from
Jan 9, 2024

Conversation

qrkourier
Copy link
Member

No description provided.

@qrkourier qrkourier linked an issue Jan 9, 2024 that may be closed by this pull request
Copy link

vercel bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
zrok ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2024 9:46pm

Copy link
Collaborator

@michaelquigley michaelquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

…is never seen by client at this stage before it's passed to backend
Copy link
Collaborator

@michaelquigley michaelquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the one thing, this is great.

endpoints/publicProxy/http.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@michaelquigley michaelquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable... 👍

@qrkourier qrkourier merged commit 3cb249e into main Jan 9, 2024
5 checks passed
@qrkourier qrkourier deleted the 512-delete-the-auth-cookie-if-its-not-needed branch January 9, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

delete the auth cookie if it's not needed
2 participants