Skip to content
This repository was archived by the owner on Jul 30, 2021. It is now read-only.

Updating Seldon Community Operator from 2.8 to 3.1 #513

Conversation

axsaucedo
Copy link
Contributor

This pull request contains the changes required to update the Seldon Community Operator from 2.8 to 3.1 (CSV versions 0.1.2 to 0.1.3).

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 12, 2019
@openshift-ci-robot
Copy link
Collaborator

Hi @axsaucedo. Thanks for your PR.

I'm waiting for a operator-framework or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tmckayus
Copy link
Contributor

@aneeshkp ptal

@tmckayus
Copy link
Contributor

Note that the deployment name for the seldon controller was changed to get around the issue reported in operator-framework/operator-lifecycle-manager#952 (the selector/labels for the controller deployment changed)

@tmckayus
Copy link
Contributor

tmckayus commented Jul 12, 2019

Looks like sedonoperator.crd.yaml needs the status subresource added, this is apparently why the scorecard is failing (there is no status block!)

seldonoperator-crd-yaml.txt
@axsaucedo

@axsaucedo
Copy link
Contributor Author

Thank you @tmckayus - this has been updated with the latest CSV.

@aneeshkp aneeshkp added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 15, 2019
@aneeshkp
Copy link
Contributor

/test CVP

@aneeshkp
Copy link
Contributor

/ok-to-test

@aneeshkp
Copy link
Contributor

/retest

@aneeshkp aneeshkp merged commit 15a2da7 into operator-framework:master Jul 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants