ansible: support disabling reconciliation

- Enforce the "default" reconcilePeriod to be > 0
- Enforce reconcilePeriod for a particular GVK to be >= 0

pkg/ansible/controller/controller.go

@@ -49,9 +49,6 @@ func Add(mgr manager.Manager, options Options) {
 		options.EventHandlers = []events.EventHandler{}
 	}
 	eventHandlers := append(options.EventHandlers, events.NewLoggingEventHandler(options.LoggingLevel))
-	if options.ReconcilePeriod == time.Duration(0) {
-		options.ReconcilePeriod = time.Minute
-	}
 
 	aor := &AnsibleOperatorReconciler{
 		Client:          mgr.GetClient(),

pkg/ansible/operator/operator.go

@@ -36,6 +36,9 @@ func Run(done chan error, mgr manager.Manager, watchesPath string, reconcilePeri
 		done <- err
 		return
 	}
+	if reconcilePeriod <= time.Duration(0) {
+		reconcilePeriod = time.Minute
+	}
 	rand.Seed(time.Now().Unix())
 	c := signals.SetupSignalHandler()
 

pkg/ansible/runner/runner.go

@@ -248,7 +248,7 @@ func (r *runner) Run(ident string, u *unstructured.Unstructured, kubeconfig stri
 
 // GetReconcilePeriod - new reconcile period.
 func (r *runner) GetReconcilePeriod() (time.Duration, bool) {
-	if r.reconcilePeriod == time.Duration(0) {
+	if r.reconcilePeriod < time.Duration(0) {
 		return r.reconcilePeriod, false
 	}
 	return r.reconcilePeriod, true

pkg/ansible/runner/runner_test.go

@@ -99,6 +99,11 @@ func TestNewFromWatches(t *testing.T) {
 			path:        "testdata/invalid_duration.yaml",
 			shouldError: true,
 		},
+		{
+			name:        "error negative duration",
+			path:        "testdata/negative_duration.yaml",
+			shouldError: true,
+		},
 		{
 			name: "valid watches file",
 			path: "testdata/valid.yaml",
@@ -133,6 +138,19 @@ func TestNewFromWatches(t *testing.T) {
 						Vars: map[string]interface{}{"sentinel": "finalizer_running"},
 					},
 				},
+				schema.GroupVersionKind{
+					Version: "v1alpha1",
+					Group:   "app.example.com",
+					Kind:    "NoReconcile",
+				}: runner{
+					GVK: schema.GroupVersionKind{
+						Version: "v1alpha1",
+						Group:   "app.example.com",
+						Kind:    "NoReconcile",
+					},
+					Path:            validTemplate.ValidPlaybook,
+					reconcilePeriod: time.Duration(0),
+				},
 				schema.GroupVersionKind{
 					Version: "v1alpha1",
 					Group:   "app.example.com",

pkg/ansible/runner/testdata/negative_duration.yaml

@@ -0,0 +1,6 @@
+---
+- version: v1alpha1
+  group: app.example.com
+  kind: NegativeReconcile
+  playbook: /opt/ansible/playbook.yaml
+  reconcilePeriod: -2s

pkg/ansible/runner/testdata/valid.yaml.tmpl

@@ -13,6 +13,11 @@
     role: {{ .ValidRole }}
     vars:
       sentinel: finalizer_running
+- version: v1alpha1
+  group: app.example.com
+  kind: NoReconcile
+  playbook: {{ .ValidPlaybook }}
+  reconcilePeriod: 0s
 - version: v1alpha1
   group: app.example.com
   kind: Role