Skip to content

Commit

Permalink
pkg/scaffold/helm/chart.go: comment to explain decision not to use hy…
Browse files Browse the repository at this point in the history
…phens in scaffolded chart name
  • Loading branch information
joelanford committed Feb 4, 2019
1 parent ffc48cf commit dddd92d
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions pkg/scaffold/helm/chart.go
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,9 @@ func scaffoldChart(destDir, apiVersion, kind string) (*scaffold.Resource, *chart
}

chartfile := &chart.Metadata{
// Many helm charts use hyphenated names, but we chose not to because
// of the issues related to how hyphens are interpreted in templates.
// See https://github.com/helm/helm/issues/2192
Name: r.LowerKind,
Description: "A Helm chart for Kubernetes",
Version: "0.1.0",
Expand Down

0 comments on commit dddd92d

Please sign in to comment.