Custom flags for test local (no go test ones)

[smiklosovic]

Feature Request

Is your feature request related to a problem? Please describe.

I see there in memcached example in main that you are doing flag.String("image") but this flag is set in stone in operator-sdk in test command.

If I want to add my flag (as I have other properties to set, specific to my test), I can not propagate any to "test local" because operator-sdk and go test itself does not recognise them.

Describe the solution you'd like

I want to be able to specify my own additional flags.

[AlexNPavel]

You should be able to pass the flags to your test using --go-test-flags. That flag simply appends the string you give it (split by spaces) to go test, which then passes it to the test that is being run if it does not match one of go test's own flags. The only requirement would be putting the code to add the flags before the call to test.MainEntry(m), the same way that the sdk's own e2e tests do.

[smiklosovic]

@AlexNPavel I was doing that, the go test way with my flags, but I remember that it said that go test does no recognise these flags I am trying to pass and it failed. I am doing it via env properties instead. Are you 100% I can do that?

[smiklosovic]

image flag is in operator-sdk test subcommand itself so it is recognised hence parsed from flag but I have not seen any other case when something completely custom is passed to that.

[nikhil-thomas]

You should be able to pass the flags to your test using --go-test-flags. That flag simply appends the string you give it (split by spaces) to go test, which then passes it to the test that is being run if it does not match one of go test's own flags. The only requirement would be putting the code to add the flags before the call to test.MainEntry(m), the same way that the sdk's own e2e tests do.

@AlexNPavel this works only if the flag is being used inside the test code. I believe what @smiklosovic is asking for is a way to pass a flag to operator code under test.

ie, an equivalent for --operator-flags flag in
operator-sdk up local --operator-flags command.

At present, if we use --go-test-flags, the unused flags it will not be passed to the operator code when the operator code is run locally (not on cluster).

here:

operator-sdk/pkg/test/main_entry.go

Line 77 in e9e59c0

localCmd = exec.Command(outputBinName)

[nikhil-thomas]

i have made a PR addressing this issue.
Could you guys take a look. #1509

[smiklosovic]

@nikhil-thomas I want to do something like this

https://github.com/operator-framework/operator-sdk/blob/master/test/e2e/main_test.go#L27

On whatever flag, not just image.

(after looking on PR it seems like that's what it does!)

[nikhil-thomas]

yes, the idea is to pass any flag which is defined in the operator code.
for development, we have
operator-sdk up local --operator-flags "flag1=val1 flag2=val2"

my PR adds that functionality to --up-local testing
operator-sdk test lcoal --namespace test-operator-namespace --up-local --local-operator-flags "flag1=val1 flag2=val2"