CSV versioning #1016
Merged
CSV versioning #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* internal/.../file_util.go: only set fw.Fs if not set
… ConcatCRD paths * commands/.../gen-csv.go: --from-version to specify CSV version to update * doc/sdk-cli-reference.md: update CLI doc to reflect olm-catalog changes * hack/tests/scorecard-subcommand.sh: update CSV name to renamed CSV in testdata * test/test-framework/.../memcached-operator.v0.0.2.clusterserviceversion.yaml: rename to reflect new CSV path structure
estroz
added
kind/feature
estroz
requested review from
joelanford,
shawn-hurley,
AlexNPavel,
lilic and
hasbro17
openshift-ci-robot
added
do-not-merge/work-in-progress
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
which direct gen-csv to update CRD's in the created/updated CSV dir commands/.../scorecard/olm_tests.go: move getCRDs to k8sutil internal/util/k8sutil/crd.go: move getCRDs here from scorecard
internal/util/k8sutil/crd.go: move getCRDs here from scorecard
AlexNPavel
approved these changes
Feb 11, 2019
lilic
reviewed
Feb 14, 2019
Co-Authored-By: estroz <[email protected]>
joelanford
approved these changes
Feb 15, 2019
There was a problem hiding this comment.
LGTM
Unrelated to this PR, but I was testing it out and realized I didn't know how to fill in the extra fields that are left empty by the default scaffolding. Maybe should consider filling those will placeholders or adding a link to the message for documentation about CSVs.
openshift-ci-robot
added
the
needs-rebase
hasbro17
reviewed
Feb 18, 2019
openshift-ci-robot
removed
the
needs-rebase
hasbro17
approved these changes
Feb 20, 2019
This was referenced Feb 20, 2019
estroz
added a commit
that referenced
this pull request
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change: implement CSV directory and file versioning. Added
--update-crdsand--crds-dirflags so CRD's can optionally be copied fromdeploy/crdswhen creating a new CSV or updating an existing CSV. See #900 for more details.Motivation for the change: see #900