Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/ansible: Update the running condition when reconcile happens #1066

Merged

Conversation

shawn-hurley
Copy link
Member

Description of the change:

  • will alert the user to when reconcile is happening
  • will show the user the last results from ansible
  • handles the case when the operator is failing.

Motivation for the change:
Better messaging to users when things are happening.

@shawn-hurley shawn-hurley added kind/bug Categorizes issue or PR as related to a bug. language/ansible Issue is related to an Ansible operator project v0.4.x labels Feb 6, 2019
@shawn-hurley shawn-hurley requested a review from fabianvf February 6, 2019 14:40
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 6, 2019
@shawn-hurley
Copy link
Member Author

shawn-hurley commented Feb 6, 2019

@johnkim76 @jmrodri @alaypatel07 do you guys want to take a quick look at this PR?

* will alert the user to when reconcile is happening
* will show the user the last results from ansible
* handles the case when the operator is failing.
@shawn-hurley shawn-hurley force-pushed the bug/update-status-0.4 branch from 5cc4cac to d8db218 Compare February 6, 2019 15:11
@jmrodri
Copy link
Member

jmrodri commented Feb 6, 2019

LGTM

@shawn-hurley shawn-hurley merged commit 09d0d70 into operator-framework:v0.4.x Feb 6, 2019
shawn-hurley pushed a commit to shawn-hurley/operator-sdk that referenced this pull request Apr 23, 2019
…rator-framework#1066)

**Description of the change:**
* will alert the user to when reconcile is happening
* will show the user the last results from ansible
* handles the case when the operator is failing.

**Motivation for the change:**
Better messaging to users when things are happening.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. language/ansible Issue is related to an Ansible operator project size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants