Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] pkg/helm: custom storage backend per CR with ownerref #1100

Closed

Conversation

joelanford
Copy link
Member

@joelanford joelanford commented Feb 13, 2019

Description of the change:

This PR replaces the in-memory storage driver with a new custom storage driver that aligns with the primary design proposals for helm v3 storage:

  • Store the release state objects in the same namespace as the CR and release
  • Use secrets to store release state
  • Add owner references to release secrets

Motivation for the change:

This PR is an alternative to and would resolve the motivation for #917, the goal of which is to persist release state as cluster resources rather than use Helm's in-memory storage backend.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 13, 2019
@openshift-ci-robot
Copy link

@joelanford: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2019
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 1, 2019
@openshift-ci-robot
Copy link

@joelanford: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-ansible 02bcf76 link /test e2e-aws-ansible
ci/prow/images 02bcf76 link /test images

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@joelanford
Copy link
Member Author

This is mostly OBE. The only additional feature of this PR that isn't already present is the addition of owner references on the release secrets, pointing the to CR that controls the release.

We'll likely re-evaluate this with Helm 3 (which will require a different changeset anyway).

@joelanford joelanford closed this Jun 27, 2019
@joelanford joelanford deleted the helm-custom-storage branch June 27, 2019 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants