Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/util/yamlutil: fix empty yaml bug #1258

Merged
merged 1 commit into from
Mar 28, 2019

Conversation

AlexNPavel
Copy link
Contributor

Description of the change: Check length of yaml token after trimming spaces

Motivation for the change: Fix #1225

@AlexNPavel AlexNPavel added the kind/bug Categorizes issue or PR as related to a bug. label Mar 27, 2019
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 27, 2019
@estroz
Copy link
Member

estroz commented Mar 27, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2019
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is it worth adding a unit test for this?

@AlexNPavel AlexNPavel merged commit 5a439ae into operator-framework:master Mar 28, 2019
@AlexNPavel AlexNPavel deleted the fix-scan branch March 28, 2019 17:18
AlexNPavel added a commit to AlexNPavel/operator-sdk that referenced this pull request Apr 1, 2019
**Description of the change:** Check length of yaml token after trimming spaces


**Motivation for the change:** Fix operator-framework#1225
AlexNPavel added a commit that referenced this pull request Apr 2, 2019
* internal/util/yamlutil: fix empty yaml bug (#1258)

* CHANGELOG.md: update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants