pkg/log/zap: Adding ability to get client-go and trace level logs #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
|
/cc @jmrodri @joelanford |
joelanford
approved these changes
Apr 12, 2019
shawn-hurley
force-pushed
the
feature/add-log-levels
branch
from
ce17a5b to
c11d758
Compare
|
/lgtm |
hasbro17
reviewed
Apr 15, 2019
pkg/log/zap/flags.go
Outdated
| if lvl < -3 { | ||
| fs := flag.NewFlagSet("", flag.ContinueOnError) | ||
| klog.InitFlags(fs) | ||
| fs.Set("v", fmt.Sprintf("%v", -1*lvl)) |
There was a problem hiding this comment.
Check the returned error?
|
Also it might be worth adding a line somewhere in the logging user doc to mention this behavior beyond just the CHANGELOG. |
|
New changes are detected. LGTM label has been removed. |
hasbro17
approved these changes
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Adding the ability to set the log level for klog if the zap-level is for enough verbosity.
Motivation for the change:
Allowing users to get more debug level logs with help when diagnosing problems.