Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(backport to v0.8.x) Helm: RBAC generation fixes #1467

Merged
merged 2 commits into from
May 21, 2019

Conversation

joelanford
Copy link
Member

Description of the change:
Backports #1461 to v0.8.x branch

Motivation for the change:
To fix this bug in the latest release

* internal/pkg/scaffold/helm/role.go: return on role generation error

* internal/pkg/scaffold/helm/role.go: handle OCP k8s versions

* hack/tests/e2e-helm.sh: fail on failed RBAC generation

* CHANGELOG.md: added lines for fixes from operator-framework#1456 and operator-framework#1461
@joelanford joelanford requested a review from hasbro17 May 21, 2019 18:40
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 21, 2019
@joelanford joelanford added kind/bug Categorizes issue or PR as related to a bug. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 21, 2019
@joelanford
Copy link
Member Author

FYI - this won't pass until #1466 has been merged into v0.8.x (but this does prove that the e2e fixes are working)

@joelanford joelanford added backport This PR is a backport size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 21, 2019
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joelanford joelanford merged commit 5284ed3 into operator-framework:v0.8.x May 21, 2019
@joelanford joelanford deleted the backport-1461 branch May 21, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport This PR is a backport kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants