internal/pkg/scaffold: fix versions for go mod proxy #1632
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
|
/test marker |
|
/test e2e-aws-ansible |
1 similar comment
|
/test e2e-aws-ansible |
|
/test e2e-aws-ansible |
1 similar comment
|
/test e2e-aws-ansible |
|
/test e2e-aws-ansible |
1 similar comment
|
/test e2e-aws-ansible |
|
/test e2e-aws-helm |
|
@joelanford: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
This is obsolete now that #1566 has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
As a follow on to #1612, this PR changes the timestamps in the go mod scaffolds for
k8s.io/apiandk8s.io/apimachineryso that GOPROXY can be used when building scaffolded projects.Motivation for the change:
Oddly, when
GOPROXY=https://proxy.golang.orgthe e2e tests on master fail with an error about an invalid module version:For some reason, without GOPROXY set,
go buildaccepts both old and new version strings.