Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Ansible Images #1947

Merged
merged 12 commits into from
Sep 27, 2019
Merged

Upgrade Ansible Images #1947

merged 12 commits into from
Sep 27, 2019

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Sep 20, 2019 •
edited
Loading

Description of the change:

  • Upgrade the python version 2 which is deprecated to 3.
  • Upgrade ansible version and it deps/utilities too
  • Use yum update

Motivation for the change:

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2019
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 20, 2019
@camilamacedo86 camilamacedo86 changed the title WIP : Python ubi upgrade WIP : Python ubi upgrade ( Please NOT review it YET ) Sep 20, 2019
@camilamacedo86 camilamacedo86 changed the title WIP : Python ubi upgrade ( Please NOT review it YET ) WIP : Please NOT review it Sep 20, 2019
@camilamacedo86 camilamacedo86 changed the title WIP : Please NOT review it WIP: Python ubi upgrade. Sep 20, 2019
@camilamacedo86 camilamacedo86 changed the title WIP: Python ubi upgrade. Upgrade Python version from 2 to 3 Sep 20, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2019
@camilamacedo86 camilamacedo86 mentioned this pull request Sep 20, 2019
Closed
@camilamacedo86 camilamacedo86 changed the title Upgrade Python version from 2 to 3 [Blocked] - Upgrade Python version from 2 to 3 Sep 20, 2019
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 20, 2019
@camilamacedo86 camilamacedo86 changed the title [Blocked] - Upgrade Python version from 2 to 3 [Blocked] WIP - Upgrade Python version from 2 to 3 Sep 20, 2019
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 20, 2019
@camilamacedo86 camilamacedo86 changed the title [Blocked] WIP - Upgrade Python version from 2 to 3 WIP - Upgrade Python version from 2 to 3 Sep 22, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2019
@camilamacedo86 camilamacedo86 changed the title WIP - Upgrade Python version from 2 to 3 Upgrade Python version from 2 to 3 Sep 22, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2019
fabianvf
fabianvf suggested changes Sep 27, 2019
View reviewed changes
Copy link
Member

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, one or two issues and a couple nits

test/ansible-inventory/molecule/test-local/asserts.yml Show resolved Hide resolved
test/ansible-inventory/molecule/test-local/playbook.yml Show resolved Hide resolved
test/ansible-inventory/molecule/test-local/playbook.yml Show resolved Hide resolved
test/ansible-inventory/molecule/test-local/prepare.yml Show resolved Hide resolved
test/ansible-inventory/plugins/filter/test.py Show resolved Hide resolved
CHANGELOG.md Outdated
@@ -46,6 +46,7 @@
```
- [`pkg/test.FrameworkClient`](https://github.com/operator-framework/operator-sdk/blob/master/pkg/test/client.go#L33) methods `List()` and `Delete()` have new signatures corresponding to the homonymous methods of `sigs.k8s.io/controller-runtime/pkg/client.Client`. ([#1876](https://github.com/operator-framework/operator-sdk/pull/1876))
- CRD file names were previously of the form `<group>_<version>_<kind>_crd.yaml`. Now that CRD manifest `spec.version` is deprecated in favor of `spec.versions`, i.e. multiple versions can be specified in one CRD, CRD file names have the form `<full group>_<resource>_crd.yaml`. `<full group>` is the full group name of your CRD while `<group>` is the last subdomain of `<full group>`, ex. `foo.bar.com` vs `foo`. `<resource>` is the plural lower-case CRD Kind found at `spec.names.plural`. ([#1876](https://github.com/operator-framework/operator-sdk/pull/1876))
- Upgrade Python version from `2.7` to `3.6`, Ansible version from `2.8.0` to `2.8.5` and ansible-runner from `1.2` to `1.3.4` in the Ansible based images. ([#1947](https://github.com/operator-framework/operator-sdk/pull/1947))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

test/ansible-inventory/inventory/hosts Outdated Show resolved Hide resolved
@camilamacedo86
Upgrade Python, Ansible and ansible-runner versions for Ansible base…
1fe1b18 
…d images

* download and install the inotify-tools which is no longer avaible in the ubi8//epel-release-latest-8
* use pip3 in all places
* changes in the ci/trevis in order to work with python3
* ajust pip and python to work in ubi7
* increase the timeout to check the reconcile
* upgrade ansible and its deps versions
* upgrade to use molecule 2.22
* apply make generated inventory define implicit localhost #1828
@camilamacedo86
add ansible_python_interpreter=/usr/bin/python3 in host inventory
3d76a68
@camilamacedo86
improve test names in order to be able to identify them
5987a11
@camilamacedo86
add interpreter in the py file
7b6c1ec
@camilamacedo86
python changes in the molecule test
198ceb1
@camilamacedo86
add host var for all hosts
c152661
@camilamacedo86
Wait 2m for reconciliation to run
fcf7e52
@camilamacedo86
solve ansible [WARNING]: The value 8443 (type int)
4044089
@camilamacedo86
Copy link
Contributor Author

/test e2e-aws-subcommand
/test e2e-aws-helm
/test e2e-aws-ansible

estroz
estroz approved these changes Sep 27, 2019
View reviewed changes
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Lets wait for @fabianvf to approve before merging.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2019
fabianvf
fabianvf approved these changes Sep 27, 2019
View reviewed changes
Copy link
Member

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@camilamacedo86
Copy link
Contributor Author

/test e2e-aws-subcommand
/test e2e-aws-helm
/test e2e-aws-ansible

1 similar comment
@camilamacedo86
Copy link
Contributor Author

/test e2e-aws-subcommand
/test e2e-aws-helm
/test e2e-aws-ansible

@camilamacedo86
Copy link
Contributor Author

/test e2e-aws-subcommand

1 similar comment
@camilamacedo86
Copy link
Contributor Author

/test e2e-aws-subcommand

@camilamacedo86 camilamacedo86 merged commit ebac354 into operator-framework:master Sep 27, 2019
@camilamacedo86 camilamacedo86 deleted the python-ubi-upgrade branch September 27, 2019 21:34
@camilamacedo86 camilamacedo86 mentioned this pull request Oct 9, 2019
Closed
@camilamacedo86 camilamacedo86 mentioned this pull request Oct 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianvf fabianvf fabianvf approved these changes

@estroz estroz estroz approved these changes

@AlexNPavel AlexNPavel Awaiting requested review from AlexNPavel

@joelanford joelanford Awaiting requested review from joelanford

@jmccormick2001 jmccormick2001 Awaiting requested review from jmccormick2001

@jmrodri jmrodri Awaiting requested review from jmrodri

Assignees

@fabianvf fabianvf

@estroz estroz

Labels
lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@camilamacedo86 @estroz @fabianvf @openshift-ci-robot