scaffold: printVersion includes operator's Version #1953

drnic · 2019-09-21T21:05:58Z

Description of the change:

The scaffold for Operator bootstrapping now includes the Operator's version.Version.

Motivation for the change:

Currently an Operator built from scaffold does not print the Operator's version.Version

(This is my first PR; sorry if there is additional context you need, or if you're not looking for this type of PR)

openshift-ci-robot · 2019-09-21T21:06:18Z

Hi @drnic. Thanks for your PR.

I'm waiting for a operator-framework or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

estroz · 2019-09-23T21:39:30Z

@drnic thanks for submitting a PR! This change is a nice-to-have.

/ok-to-test

internal/pkg/scaffold/cmd.go

internal/pkg/scaffold/cmd_test.go

drnic · 2019-09-25T07:00:04Z

I’ll investigate the CI failure soon. Sorry about that.

internal/pkg/scaffold/cmd.go

internal/pkg/scaffold/cmd_test.go

drnic · 2019-09-26T01:46:01Z

Any pro tips for debugging/fixing this?

estroz · 2019-09-27T23:19:29Z

/test e2e-aws-go
/test e2e-aws-ansible

drnic · 2019-09-28T00:31:06Z

Hurray! The simple delights of CI passing.

camilamacedo86

Hi @djzager,

Thank you for your contribution.

It is missing the CHANGELOG entry. Could you please add it?
Also, IMHO it would be better Operator Version instead of just Version in order to make clear from where came the version. Do not you agree? WDYT?

internal/pkg/scaffold/cmd.go

internal/pkg/scaffold/cmd_test.go

camilamacedo86

It was tested locally and all worked fine.
Asked for a few nits and add Changelog.

/lgtm
/approve

 $ operator-sdk up local 
INFO[0000] Running the operator locally.                
INFO[0000] Using namespace default.                     
{"level":"info","ts":1570560195.7755609,"logger":"cmd","msg":"Version: 0.0.1"}
{"level":"info","ts":1570560195.775807,"logger":"cmd","msg":"Go Version: go1.12.10"}
{"level":"info","ts":1570560195.775821,"logger":"cmd","msg":"Go OS/Arch: darwin/amd64"}
{"level":"info","ts":1570560195.775827,"logger":"cmd","msg":"Version of operator-sdk: v0.10.0+git"}
{"level":"info","ts":1570560195.776957,"logger":"leader","msg":"Trying to become the leader."}
{"level":"info","ts":1570560195.7769878,"logger":"leader","msg":"Skipping leader election; not running in a cluster."}

drnic · 2019-10-09T15:22:54Z

Fixed minor suggestions + rebased against master.

camilamacedo86 · 2019-10-09T16:32:22Z

/lgtm
/approve

joelanford

LGTM once CHANGELOG is updated.

camilamacedo86 · 2019-10-09T16:41:22Z

Hi @drnic,

It still missing the changelog entry. The commit for it maybe needs to be pushed.

openshift-ci-robot · 2019-10-09T19:15:31Z

New changes are detected. LGTM label has been removed.

drnic · 2019-10-09T19:15:55Z

Sorry, I missed the request for CHANGELOG update earlier.

CHANGELOG.md

camilamacedo86 · 2019-10-13T10:55:42Z

CHANGELOG.md

@@ -8,6 +8,7 @@
 - Ansible based operators now gather and serve metrics about each custom resource on port 8686 of the metrics service. ([#1723](https://github.com/operator-framework/operator-sdk/pull/1723))
 - Added the Go version, OS, and architecture to the output of `operator-sdk version` ([#1863](https://github.com/operator-framework/operator-sdk/pull/1863))
 - Added support for `ppc64le-linux` for the `operator-sdk` binary and the Helm operator base image. ([#1533](https://github.com/operator-framework/operator-sdk/pull/1533))
+-  Added `Operator Version: X.Y.Z` information in the operator logs.([#1953](https://github.com/operator-framework/operator-sdk/pull/1953))


Since we have the release of 0.11.
In order, we are able to merge its required: rebase the PR with the master branch and move this entry for the UNRELEASED section. Could you help us with @drnic? Also, in order to avoid rebase conflicts I would suggest to you keep the update changelog in a another commit, is it possible?

@camilamacedo86 ok, done

HI @drnic,

I think maybe you forget to push the change. This entry needs to be moved for here.

And really tks for your contribution 🥇
iIt is very important to us.

Oh you released 0.11 without this PR. Sorry.

I kept the PR as two commits and fixed/updated your CHANGELOG update commit.

openshift-ci-robot · 2019-10-13T20:16:18Z

New changes are detected. LGTM label has been removed.

camilamacedo86 · 2019-10-14T18:23:51Z

/test e2e-aws-go
/test e2e-aws-ansible

openshift-bot · 2019-10-14T20:15:29Z

/retest

Please review the full test history for this PR and help us cut down flakes.

joelanford

My only concern here is that I'm not sure how many SDK users are aware of the version package that gets scaffolded into their projects. However, since this affects only scaffolded code that can be changed by users and only newly scaffolded projects, it isn't really a problem.

LGTM, after fixing nits in CHANGELOG.

CHANGELOG.md

Currently an Operator built from scaffold does not print the Operator's version.Version

Co-Authored-By: Camila Macedo <[email protected]>

openshift-ci-robot · 2019-10-14T21:01:23Z

New changes are detected. LGTM label has been removed.

openshift-ci-robot requested review from hasbro17 and joelanford September 21, 2019 21:06

openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 21, 2019

openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 21, 2019

openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 23, 2019

estroz reviewed Sep 23, 2019

View reviewed changes

internal/pkg/scaffold/cmd.go Outdated Show resolved Hide resolved

estroz reviewed Sep 23, 2019

View reviewed changes

internal/pkg/scaffold/cmd_test.go Outdated Show resolved Hide resolved

drnic force-pushed the print-version-self branch from b562ed8 to 4dbafc4 Compare September 25, 2019 06:28

estroz reviewed Sep 25, 2019

View reviewed changes

internal/pkg/scaffold/cmd.go Outdated Show resolved Hide resolved

estroz reviewed Sep 25, 2019

View reviewed changes

internal/pkg/scaffold/cmd_test.go Outdated Show resolved Hide resolved

drnic force-pushed the print-version-self branch from 4dbafc4 to 9630552 Compare September 25, 2019 21:55

camilamacedo86 suggested changes Oct 8, 2019

View reviewed changes

camilamacedo86 reviewed Oct 8, 2019

View reviewed changes

internal/pkg/scaffold/cmd.go Outdated Show resolved Hide resolved

camilamacedo86 reviewed Oct 8, 2019

View reviewed changes

internal/pkg/scaffold/cmd_test.go Outdated Show resolved Hide resolved

camilamacedo86 approved these changes Oct 8, 2019

View reviewed changes

openshift-ci-robot assigned camilamacedo86 Oct 8, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2019

drnic force-pushed the print-version-self branch from 9630552 to 0ed388e Compare October 9, 2019 15:22

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2019

joelanford approved these changes Oct 9, 2019

View reviewed changes

drnic force-pushed the print-version-self branch from 0ed388e to 396fdbe Compare October 9, 2019 19:15

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2019

camilamacedo86 reviewed Oct 9, 2019

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

camilamacedo86 added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Oct 10, 2019

camilamacedo86 reviewed Oct 13, 2019

View reviewed changes

drnic force-pushed the print-version-self branch from 0dfde04 to 1ec794c Compare October 13, 2019 20:16

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2019

drnic force-pushed the print-version-self branch from 1ec794c to dfa04a9 Compare October 13, 2019 20:54

camilamacedo86 added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2019

joelanford approved these changes Oct 14, 2019

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

drnic and others added 2 commits October 15, 2019 08:00

scaffold: printVersion includes operator's Version

f73031a

Currently an Operator built from scaffold does not print the Operator's version.Version

Update CHANGELOG.md

3ba62e5

Co-Authored-By: Camila Macedo <[email protected]>

drnic force-pushed the print-version-self branch from dfa04a9 to 3ba62e5 Compare October 14, 2019 21:01

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2019

camilamacedo86 merged commit 99021fa into operator-framework:master Oct 16, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

scaffold: printVersion includes operator's Version #1953

scaffold: printVersion includes operator's Version #1953

drnic commented Sep 21, 2019

openshift-ci-robot commented Sep 21, 2019

estroz commented Sep 23, 2019

drnic commented Sep 25, 2019 via email •

edited

Loading

drnic commented Sep 26, 2019 via email •

edited

Loading

estroz commented Sep 27, 2019

drnic commented Sep 28, 2019

camilamacedo86 left a comment •

edited

Loading

camilamacedo86 left a comment

drnic commented Oct 9, 2019

camilamacedo86 commented Oct 9, 2019

joelanford left a comment •

edited

Loading

camilamacedo86 commented Oct 9, 2019

openshift-ci-robot commented Oct 9, 2019

drnic commented Oct 9, 2019

camilamacedo86 Oct 13, 2019 •

edited

Loading

drnic Oct 13, 2019

camilamacedo86 Oct 13, 2019

drnic Oct 13, 2019

drnic Oct 13, 2019

openshift-ci-robot commented Oct 13, 2019

camilamacedo86 commented Oct 14, 2019

openshift-bot commented Oct 14, 2019

joelanford left a comment

openshift-ci-robot commented Oct 14, 2019

scaffold: printVersion includes operator's Version #1953

scaffold: printVersion includes operator's Version #1953

Conversation

drnic commented Sep 21, 2019

openshift-ci-robot commented Sep 21, 2019

estroz commented Sep 23, 2019

drnic commented Sep 25, 2019 via email • edited Loading

drnic commented Sep 26, 2019 via email • edited Loading

estroz commented Sep 27, 2019

drnic commented Sep 28, 2019

camilamacedo86 left a comment • edited Loading

Choose a reason for hiding this comment

camilamacedo86 left a comment

Choose a reason for hiding this comment

drnic commented Oct 9, 2019

camilamacedo86 commented Oct 9, 2019

joelanford left a comment • edited Loading

Choose a reason for hiding this comment

camilamacedo86 commented Oct 9, 2019

openshift-ci-robot commented Oct 9, 2019

drnic commented Oct 9, 2019

camilamacedo86 Oct 13, 2019 • edited Loading

Choose a reason for hiding this comment

drnic Oct 13, 2019

Choose a reason for hiding this comment

camilamacedo86 Oct 13, 2019

Choose a reason for hiding this comment

drnic Oct 13, 2019

Choose a reason for hiding this comment

drnic Oct 13, 2019

Choose a reason for hiding this comment

openshift-ci-robot commented Oct 13, 2019

camilamacedo86 commented Oct 14, 2019

openshift-bot commented Oct 14, 2019

joelanford left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Oct 14, 2019

drnic commented Sep 25, 2019 via email •

edited

Loading

drnic commented Sep 26, 2019 via email •

edited

Loading

camilamacedo86 left a comment •

edited

Loading

joelanford left a comment •

edited

Loading

camilamacedo86 Oct 13, 2019 •

edited

Loading