-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: error in Do will never return to outer scope #1976
bugfix: error in Do will never return to outer scope #1976
Conversation
Hi @beautytiger. Thanks for your PR. I'm waiting for a operator-framework or openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3991295
to
13a7875
Compare
Hi @beautytiger, Thank you for your contribution. 🥇 |
This looks reasonable, the reporter is correct we're eating errors here. |
/ok-to-test |
eb9ea74
to
4c065b5
Compare
@camilamacedo86 |
Hi @beautytiger, It shows great now. 👍 It is just missing one detail. Could you please add an entry in the CHANGELOG with the fix as it is done for the others. The change is here, you . can check the others entry as an example over what is expected. |
4c065b5
to
a380a1b
Compare
@camilamacedo86 |
/lgtm |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🥇
Thank you for your contribution.
fb98e85
to
fb73a63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/test e2e-aws-ansible |
1 similar comment
/test e2e-aws-ansible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one fix in the CHANGELOG. Otherwise, LGTM.
Signed-off-by: Guangming Wang <[email protected]>
1460084
to
af26321
Compare
New changes are detected. LGTM label has been removed. |
Description of the change:
func in
Do
declared a new local err, it will never be return to outer scope.Motivation for the change:
fix this bug