-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to controller-runtime 0.3.0 and Kubernetes 1.15 #2083
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f6229f4
Bump kubernetes dependencies to 1.15.4
joelanford 751e818
bump controller-tools to v0.2.2
joelanford 3384799
CHANGELOG.md: add lines for #2083
joelanford bcf73d2
internal/pkg/scaffold/crd.go: remove controller-gen annotation
joelanford c3964b5
doc/dev/release.md: tweak release instructions for go.mod changes
joelanford e6804a7
go.mod,go.sum: minor cleanup
joelanford File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be communicated as a breaking change to SDK users? Or even be in the CHANGELOG at all?
I don't think they're expected to use controller-tools as a dependency.
https://github.com/operator-framework/operator-sdk/blob/master/internal/scaffold/go_mod.go#L38-L69
That's more for the SDK CLI's internal use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It isn't listed as a breaking change unless I screwed up the markdown. I included it because it has some fixes that affect CRD generation.
I could either remove it altogether or add a link to the
v0.2.2tag to link it to the controller-tools release notes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah you're right. I misread the raw markdown for the prefix
**Breaking change:**and thought this was it's own section like we had in the last release.But yeah we should link to the release notes if we want to highlight the CRD generation bug fixes.
Same for the controller-runtime release notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because to (most?) SDK users who aren't using controller-tools directly it won't be clear why this version bump is important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I’ll make a follow-up with this and @estroz’s suggestion.