feat(ansible): make ansible verbosity configurable #2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
|
This is the last part of the work broken up from #1852 |
djzager
force-pushed
the
ansible-verbosity
branch
from
7aba14c to
3d57784
Compare
djzager
commented
Oct 21, 2019
| type cmdFuncType func(ident, inputDirPath string, maxArtifacts int) *exec.Cmd | ||
|
|
||
| func playbookCmdFunc(verbosity, path string) cmdFuncType { | ||
| return func(ident, inputDirPath string, maxArtifacts int) *exec.Cmd { |
There was a problem hiding this comment.
It may be worth creating an issue to make it possible to configure the ansibleVerbosity via an annotation on the Custom Resource. Thoughts?
There was a problem hiding this comment.
I like that idea a lot actually
asmacdo
added
the
language/ansible
|
@camilamacedo86 @jmrodri You both had a look at #1852 . This is the last PR broken up from that. |
jmrodri
requested changes
Oct 22, 2019
doc/ansible/dev/advanced_options.md
Outdated
|
|
||
| Setting the verbosity at which `ansible-runner` is run controls how verbose the | ||
| output of `ansible-playbook` will be. The normal rules for verbosity apply here | ||
| where higher values means more verbose output. Acceptable values range from 0 |
There was a problem hiding this comment.
tense: I think it should read "higher values mean more"
|
Updates made. Let me know if I missed anything. |
Make it possible to configure the verbosity of `ansible-runner` command invocations via command line flags. The default value should be 2 to avoid unexpected changes in behavior. Also, like `maxWorkers` the `ansibleVerbosity` can be overridden per GVK with an environment variable of the form `ANSIBLE_VERBOSITY_$KIND_$GROUP`. This PR: - Adds new command line flag `ansible-verbosity` for Ansible based operators - Add internal `cmdFuncType` to runner pkg for use when constructing command functions
- word choice in advanced_options - refer to correct environment key in getAnsibleVerbosity()
djzager
force-pushed
the
ansible-verbosity
branch
from
dc1f71c to
8e2b696
Compare
|
Rebased and updated the changelog entry to put this with the unreleased. |
jmrodri
approved these changes
Oct 23, 2019
|
/retest |
|
/lgtm |
|
/retest |
asmacdo
approved these changes
Oct 23, 2019
|
/retest |
|
/retest |
|
/test e2e-aws-go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to configure the verbosity of
ansible-runnercommandinvocations via command line flags. The default value should be 2 to
avoid unexpected changes in behavior. Also, like
maxWorkerstheansibleVerbositycan be overridden per GVK with an environmentvariable of the form
ANSIBLE_VERBOSITY_$KIND_$GROUP.This PR:
ansible-verbosityfor Ansible basedoperators
cmdFuncTypeto runner pkg for use when constructingcommand functions