Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add step to use the proxy #2106

Closed
wants to merge 1 commit into from

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Oct 24, 2019

Description of the change:

  • Add a step to use the proxy
  • Upgrade kube version

Motivation for the change:

Related to #2103

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 24, 2019
@camilamacedo86 camilamacedo86 added the kind/documentation Categorizes issue or PR as related to documentation. label Oct 24, 2019
@camilamacedo86
Copy link
Contributor Author

@joelanford besides your comment that the GOPROXY is used by default in the 1.3 would not better we keep it here just in case?

@openshift-ci-robot
Copy link

@camilamacedo86: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-helm 2154144 link /test e2e-aws-helm
ci/prow/e2e-aws-ansible 2154144 link /test e2e-aws-ansible

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@joelanford
Copy link
Member

@camilamacedo86 I don't think we should include the GOPROXY change, since it theoretically should have no impact on dependency resolution.

Also, I agree we might need to change the kubernetes version compatibility info, but we probably need more discussion on that since newer versions of kubernetes have backwards compatibility guarantees. Maybe close this PR and raise this as a question in #2083?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants