Deprecated SDK impl of DynamicRESTMapper and replace its usage for controller-runtime impl #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
camilamacedo86
changed the title
camilamacedo86
commented
Dec 10, 2019
CHANGELOG.md
Outdated
|
|
||
| ### Deprecated | ||
| - Deprecated the `operator-sdk generate openapi` command. CRD generation is still supported with `operator-sdk generate crds`. It is now recommended to use [openapi-gen](https://github.com/kubernetes/kube-openapi/tree/master/cmd/openapi-gen) directly for OpenAPI code generation. The `generate openapi` subcommand will be removed in a future release. ([#2276](https://github.com/operator-framework/operator-sdk/pull/2276)) | ||
| - Deprecated the `github.com/operator-framework/operator-sdk/pkg/restmapper` since it was added to the [controller-runtime](https://github.com/operator-framework/operator-sdk/issues/2299) which is now recommended to be used instead of. ([#2309](https://github.com/operator-framework/operator-sdk/pull/2309)) | ||
|
|
There was a problem hiding this comment.
Hi @estroz,
Since you did the kubernetes-sigs/controller-runtime#554 could you please help us by doing its review and confirming my understanding and if it is ok?
…r to use the controller-runtime impl instead of
Co-Authored-By: Eric Stroczynski <[email protected]>
Co-Authored-By: Eric Stroczynski <[email protected]>
camilamacedo86
added
approved
camilamacedo86
requested review from
asmacdo,
jmccormick2001,
fabianvf and
hasbro17
camilamacedo86
commented
Dec 11, 2019
miguelsorianod
added a commit
to 3scale/3scale-operator
that referenced
this pull request
Feb 14, 2020
…er-runtime one Since operator-sdk v0.14.0 usage of DynamicRestMapper implementation done by the operator-sdk is removed and it is now provided by controller-runtime and configured and set by the operator-sdk operator-framework/operator-sdk#2309
miguelsorianod
added a commit
to 3scale/3scale-operator
that referenced
this pull request
Feb 15, 2020
…er-runtime one Since operator-sdk v0.14.0 usage of DynamicRestMapper implementation done by the operator-sdk is removed and it is now provided by controller-runtime and configured and set by the operator-sdk operator-framework/operator-sdk#2309
miguelsorianod
added a commit
to 3scale/3scale-operator
that referenced
this pull request
Feb 15, 2020
…er-runtime one Since operator-sdk v0.14.0 usage of DynamicRestMapper implementation done by the operator-sdk is removed and it is now provided by controller-runtime and configured and set by the operator-sdk operator-framework/operator-sdk#2309
miguelsorianod
added a commit
to 3scale/3scale-operator
that referenced
this pull request
Feb 17, 2020
…er-runtime one Since operator-sdk v0.14.0 usage of DynamicRestMapper implementation done by the operator-sdk is removed and it is now provided by controller-runtime and configured and set by the operator-sdk operator-framework/operator-sdk#2309
miguelsorianod
added a commit
to 3scale/3scale-operator
that referenced
this pull request
Feb 19, 2020
…er-runtime one Since operator-sdk v0.14.0 usage of DynamicRestMapper implementation done by the operator-sdk is removed and it is now provided by controller-runtime and configured and set by the operator-sdk operator-framework/operator-sdk#2309
miguelsorianod
added a commit
to 3scale/3scale-operator
that referenced
this pull request
Feb 20, 2020
…er-runtime one Since operator-sdk v0.14.0 usage of DynamicRestMapper implementation done by the operator-sdk is removed and it is now provided by controller-runtime and configured and set by the operator-sdk operator-framework/operator-sdk#2309
miguelsorianod
added a commit
to 3scale/3scale-operator
that referenced
this pull request
Feb 28, 2020
…er-runtime one Since operator-sdk v0.14.0 usage of DynamicRestMapper implementation done by the operator-sdk is removed and it is now provided by controller-runtime and configured and set by the operator-sdk operator-framework/operator-sdk#2309
miguelsorianod
added a commit
to 3scale/apicast-operator
that referenced
this pull request
Feb 28, 2020
…er-runtime one Since operator-sdk v0.14.0 usage of DynamicRestMapper implementation done by the operator-sdk is removed and it is now provided by controller-runtime and configured and set by the operator-sdk operator-framework/operator-sdk#2309
miguelsorianod
added a commit
to 3scale/3scale-operator
that referenced
this pull request
Feb 28, 2020
…er-runtime one Since operator-sdk v0.14.0 usage of DynamicRestMapper implementation done by the operator-sdk is removed and it is now provided by controller-runtime and configured and set by the operator-sdk operator-framework/operator-sdk#2309
miguelsorianod
added a commit
to 3scale/apicast-operator
that referenced
this pull request
Feb 28, 2020
…er-runtime one Since operator-sdk v0.14.0 usage of DynamicRestMapper implementation done by the operator-sdk is removed and it is now provided by controller-runtime and configured and set by the operator-sdk operator-framework/operator-sdk#2309
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change:
Closes #2299