Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commands/.../test/local,pkg/test: add no-setup flag #770

Merged
merged 11 commits into from
Nov 29, 2018
Merged

commands/.../test/local,pkg/test: add no-setup flag #770

merged 11 commits into from
Nov 29, 2018

Conversation

AlexNPavel
Copy link
Contributor

Description of the change: Adds a no-setup flag that disables creation of resources by using empty files as the manifests and restricting the test to a single namespace

Motivation for the change: Resolves #743

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 21, 2018
@AlexNPavel
Copy link
Contributor Author

/hold
I need to add tests for the new functionality

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 26, 2018
@AlexNPavel
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 27, 2018
hasbro17
hasbro17 reviewed Nov 27, 2018
View reviewed changes
pkg/test/framework.go
@@ -57,6 +57,10 @@ type Framework struct {
}

func setup(kubeconfigPath, namespacedManPath *string) error {
namespace := ""
if *singleNamespace {
namespace = os.Getenv(TestNamespaceEnv)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If len(namespace) == 0 exit with error TestNamespaceEnv must be set.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary. We default to the namespace specified in the kubeconfig in that case: https://github.com/operator-framework/operator-sdk/pull/770/files/b7ca022a01320d6b684df1d9e4cec56c86151440#diff-7ebc985f9067a44fc5791eeec5c424e2R84

@openshift-bot
Copy link

@AlexNPavel: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-bot
Copy link

@AlexNPavel: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hasbro17
hasbro17 approved these changes Nov 29, 2018
View reviewed changes
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexNPavel AlexNPavel merged commit 4565af3 into operator-framework:master Nov 29, 2018
@AlexNPavel AlexNPavel deleted the test-no-setup branch November 29, 2018 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasbro17 hasbro17 hasbro17 approved these changes

@estroz estroz Awaiting requested review from estroz

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexNPavel @openshift-bot @hasbro17 @openshift-ci-robot