pkg/ansible/controller; Remove IsAlreadyRegistered() check in controller #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
|
/hold We need to update the SDK version in Gopkg.toml to use the branch |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
shawn-hurley
added
the
language/ansible
fabianvf
approved these changes
Jan 22, 2019
shawn-hurley
pushed a commit
to shawn-hurley/operator-sdk
that referenced
this pull request
Apr 23, 2019
…ler (operator-framework#973) * pkg/ansible/controller; Remove IsVersionRegistered check * Update e2e tests to watch multiple kinds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
There is no need to skip adding the controller if the version is already registered.
Motivation for the change:
This currently breaks the ability to watch multiple kinds in the same operator.
Closes #962