commands/.../up/local: fix kubeconfig and namespace handling (#983) #996
Conversation
…r-framework#983) * commands/.../up/local: fix kubeconfig and namespace handling
AlexNPavel
requested review from
mhrivnak,
joelanford,
shawn-hurley,
lilic,
hasbro17 and
estroz
openshift-ci-robot
added
the
size/M
| // only set env var if user explicitly specified a kubeconfig path | ||
| if kubeConfig != "" { | ||
| if err := os.Setenv(k8sutil.KubeConfigEnvVar, kubeConfig); err != nil { | ||
| log.Fatalf("failed to set %s environment variable: (%v)", k8sutil.KubeConfigEnvVar, err) |
There was a problem hiding this comment.
Seems like CI is complaining about this not starting with uppercase.
| log.Fatalf("failed to set %s environment variable: (%v)", k8sutil.KubeConfigEnvVar, err) | |
| log.Fatalf("Failed to set %s environment variable: (%v)", k8sutil.KubeConfigEnvVar, err) |
There was a problem hiding this comment.
Should we backport the adjusting of logs PR, to this branch as well? Otherwise, we will always have the same problem with CI. 🤔
There was a problem hiding this comment.
I don't think it would make sense to backport that. I feel like that's too big of a change to include in a micro/patch release. We'll only have issues with logging in the commands with cherry-picks, but it's pretty easy to manual fix those problems.
|
|
||
| ### Bug Fixes | ||
|
|
||
| - Make `up local` subcommand respect `KUBECONFIG` env var ([#996](https://github.com/operator-framework/operator-sdk/pull/996)) |
There was a problem hiding this comment.
Should we also put this to ## v0.4.0, not sure the protocol we follow here with changelog, when we cherrypick things.
There was a problem hiding this comment.
We will rename the Unreleased section for this branch to v0.4.1 when that gets released. And then continue with that convention for future micro/patch versions.
…r-framework#983) (operator-framework#996) **Description of the change:** Cherry pick commit from operator-framework#983 **Motivation for the change:** It is a bug fix that applies to `v0.4.0`
Description of the change: Cherry pick commit from #983
Motivation for the change: It is a bug fix that applies to
v0.4.0