Updates GoodJob to version 3.99 #17327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed some DelayedJob leftovers (like tables etc). Can I remove all those references too? |
mereghost
force-pushed
the
maint/update-good-job
branch
2 times, most recently
from
731bebf to
5db69da
Compare
mereghost
force-pushed
the
maint/update-good-job
branch
from
5db69da to
ce43f84
Compare
|
@machisuji Is this enough for you to give it a try? |
mereghost
force-pushed
the
maint/update-good-job
branch
2 times, most recently
from
adee493 to
c9c271e
Compare
mereghost
force-pushed
the
maint/update-good-job
branch
from
c9c271e to
65de5d8
Compare
brunopagno
reviewed
Jan 7, 2025
brunopagno
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Okay I'm marking this as approved as I tested a few things with success:
- switched to this branch
- ran the migrations
- created a "reminder" to validate that the worker was doing it's thing
- validated that the reminder was working as expected
- switched back from this branch to my working one
- validated that the application was still working
I think for local env this should be good enough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation steps for the eventual 4.X series upgrade.
Detailed instructions are on the gem's repo.
@machisuji Feel free to take over and run as many tests as necessary.