Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/60384 cherry pick from dev #17525

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

brunopagno
Copy link
Contributor

@brunopagno brunopagno self-assigned this Dec 31, 2024
@brunopagno brunopagno changed the base branch from dev to release/15.2 December 31, 2024 12:12
@brunopagno brunopagno marked this pull request as ready for review January 2, 2025 10:22
@brunopagno brunopagno requested a review from a team January 2, 2025 10:22
Create folder has some paths that have issues with encoding. This should fix the behaviour and guarantee that it's properly tested.
@brunopagno brunopagno force-pushed the fix/60384-cherry-pick-from-dev branch from 8049263 to a7aa05a Compare January 3, 2025 09:15
@brunopagno
Copy link
Contributor Author

The tests will never pass 🤦

@brunopagno
Copy link
Contributor Author

brunopagno commented Jan 3, 2025

I tested the failing specs on release/15.2 and on dev. They seem to be actually broken. We can fix them on a separate context.

rspec ./spec/features/work_packages/datepicker/datepicker_follows_relation_spec.rb:50 # Datepicker logic on follow relationships if the follower is a task behaves like keeps the minimum date from the predecessor when toggling NWD keeps the minimum dates disabled
rspec ./modules/my_page/spec/features/my/my_spent_time_widget_with_a_negative_time_zone_spec.rb:79 # My spent time widget with a negative time zone correctly displays non-working days and prefills day when logging time [fix #49779]
rspec ./spec/features/work_packages/datepicker/datepicker_follows_relation_spec.rb:50 # Datepicker logic on follow relationships if the follower is a milestone behaves like keeps the minimum date from the predecessor when toggling NWD keeps the minimum dates disabled
rspec ./modules/meeting/spec/features/recurring_meetings/recurring_meeting_create_spec.rb:68 # Recurring meetings creation with a user with permissions can create a recurring meeting
rspec ./modules/meeting/spec/features/recurring_meetings/recurring_meeting_crud_spec.rb:140 # Recurring meetings CRUD shows the correct actions based on status
rspec ./modules/meeting/spec/features/recurring_meetings/recurring_meeting_crud_spec.rb:92 # Recurring meetings CRUD can use the 'Create from template' button
rspec ./modules/meeting/spec/features/recurring_meetings/recurring_meeting_crud_spec.rb:106 # Recurring meetings CRUD can cancel an occurrence
rspec ./modules/meeting/spec/features/recurring_meetings/recurring_meeting_crud_spec.rb:161 # Recurring meetings CRUD with view permissions only does not allow to act on the recurring meeting
rspec ./spec/features/projects/life_cycle/overview_page/dialog/update_spec.rb:76 # Edit project stages and gates on project overview page with the dialog open when all LifeCycleSteps have a value shows all the Project::LifeCycleSteps and updates them correctly

@brunopagno brunopagno merged commit 338cb95 into release/15.2 Jan 3, 2025
10 of 11 checks passed
@brunopagno brunopagno deleted the fix/60384-cherry-pick-from-dev branch January 3, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants