[23073] Add Angular expression escaping #4536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Them gem patches Rails XSS protection methods with a replacement of `{{`
strings with `{{ DOUBLE_LEFT_CURLY_BRACE }} `.
`DOUBLE_LEFT_CURLY_BRACE` is defined by Angular to return `{{`, so we
actually do execute the interpolation, but only to return the original
string.
More information:
https://github.com/opf/rails-angular-xss
angular/angular.js#5601
|
I've prepared a stage to preview changes. Open stage or view logs. |
oliverguenther
force-pushed
the
fix/23073/template-injection
branch
from
e644177 to
4f67e1c
Compare
oliverguenther
force-pushed
the
fix/23073/template-injection
branch
from
4f67e1c to
43599a9
Compare
| @@ -95,6 +95,9 @@ gem 'rack-protection', git: 'https://github.com/finnlabs/rack-protection.git', r | |||
| # https://github.com/kickstarter/rack-attack | |||
| gem 'rack-attack' | |||
|
|
|||
| # Patch Rails HTML whitelisting for Angular curly braces | |||
| gem 'rails-angular-xss', github: 'opf/rails-angular-xss' | |||
There was a problem hiding this comment.
I seem to remember you saying that this can be removed once we have Angular 1.5 in place. If that is so, I'd like a commit in here so that we remove this gem once we no longer need it.
There was a problem hiding this comment.
We'll still need the Rails part, since the escaping issue remains for all eternity
There was a problem hiding this comment.
That sounds like a long time :(
|
There are some parts of the update to gemfile.lock that are not strictly necessary for this change but they probably can't hurt either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
rails-angular-xss, our gem forked fromangular_xssfor Rails 4.2.The gem patches Rails XSS protection methods with a replacement of
{{strings with
{{ DOUBLE_LEFT_CURLY_BRACE }}.DOUBLE_LEFT_CURLY_BRACEis defined by Angular to return{{, so weactually do execute the interpolation, but only to return the original
string.
More information:
https://github.com/opf/rails-angular-xss
angular/angular.js#5601