fix(ansible): Adding bios config job and reboot tasks in bios.yml #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rahul <[email protected]>
Signed-off-by: Rahul <[email protected]>
Signed-off-by: Rahul <[email protected]>
glimchb
reviewed
Jul 8, 2024
ansible/bios.yml
Outdated
| # TODO: configre BIOS to be always on ( see lab/hardware/dh123) and any virtualization or hyper threading settings we might need | ||
|
|
||
| - name: Debug print bios serial number | ||
| when: inventory_hostname == 'dh1bmc' |
There was a problem hiding this comment.
remove when here and rename the task from serial
glimchb
reviewed
Jul 8, 2024
ansible/bios.yml
Outdated
| # password: "{{ ansible_password }}" | ||
| # when: bios_attribute.changed | ||
| - name: Create BIOS configuration job (schedule BIOS setting update) | ||
| when: inventory_hostname == 'dh1bmc' |
There was a problem hiding this comment.
I think we should use another condition here
In previous task or from gather_facts we can already know if we talking to iDRAC or not
let's use that as a condition
glimchb
reviewed
Jul 8, 2024
ansible/bios.yml
Outdated
| # password: "{{ ansible_password }}" | ||
| # when: bios_attribute.changed | ||
| - name: Reboot system to apply new BIOS settings | ||
| when: inventory_hostname == 'dh1bmc' |
There was a problem hiding this comment.
two when statements ? one here and another one below bios_config_job.changed
glimchb
reviewed
Jul 9, 2024
ansible/bios.yml
Outdated
| # TODO: configre BIOS to be always on ( see lab/hardware/dh123) and any virtualization or hyper threading settings we might need | ||
| #- name: Debug print bios attributes | ||
| #ansible.builtin.debug: msg={{ result }} | ||
| #ansible.builtin.debug: msg={{ result.redfish_facts.bios_attribute.entries[0][1].SystemManufacturer }} |
There was a problem hiding this comment.
this is a good debug line to keep uncommented
all the rest comments should be removed
glimchb
reviewed
Jul 9, 2024
ansible/bios.yml
Outdated
| @@ -43,25 +49,30 @@ | |||
| username: "{{ ansible_user }}" | |||
| password: "{{ ansible_password }}" | |||
| register: bios_attribute | |||
| tags: ["TEST"] | |||
| # tags: ["TEST"] | |||
glimchb
reviewed
Jul 9, 2024
ansible/bios.yml
Outdated
| # password: "{{ ansible_password }}" | ||
| # when: bios_attribute.changed | ||
| - name: Create BIOS configuration job (schedule BIOS setting update) | ||
| when: result.redfish_facts.bios_attribute.entries[0][1].SystemManufacturer is defined and result.redfish_facts.bios_attribute.entries[0][1].SystemManufacturer == "Dell Inc." and bios_attribute.changed |
There was a problem hiding this comment.
let's split into lines like
Lines 72 to 76 in dabdb55
glimchb
reviewed
Jul 9, 2024
Signed-off-by: Rahul <[email protected]>
|
Will work on Boris's suggestions and submit a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.