Merged telegraf code for all hosts #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sakethanne <[email protected]>
Signed-off-by: sakethanne <[email protected]>
Signed-off-by: sakethanne <[email protected]>
glimchb
requested changes
Oct 2, 2024
There was a problem hiding this comment.
@Sakethanne can you leave only 1 commit in this PR ?
linters and md files do not belong here
glimchb
added
the
Merge Candidate
glimchb
approved these changes
Oct 2, 2024
glimchb
reviewed
Oct 2, 2024
| - inventory_hostname != 'mev' | ||
| - inventory_hostname != 'bf2' | ||
| community.docker.docker_container: | ||
| name: telegraf |
There was a problem hiding this comment.
this is not good, where are the parameters to run container ?
glimchb
reviewed
Oct 2, 2024
| [ | ||
| { | ||
| 'type': 'bind', | ||
| 'source': inventory_hostname in ['bf2', 'mev'] and '/root/telegraf.d/telegraf.conf.inventory_hostname' or |
There was a problem hiding this comment.
will '/root/telegraf.d/telegraf.conf.inventory_hostname' render to '/root/telegraf.d/telegraf.conf.bf2' and '/root/telegraf.d/telegraf.conf.mev' ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged telegraf code for all hosts