domain objects abstraction #279
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Rochford <[email protected]>
Signed-off-by: Brian Rochford <[email protected]>
glimchb
reviewed
Oct 20, 2023
pkg/objects/bridge/grpc.go
Outdated
| ) | ||
|
|
||
| // CreateLogicalBridge executes the creation of the LogicalBridge | ||
| func (s *Server) CreateLogicalBridge(ctx context.Context, in *pb.CreateLogicalBridgeRequest) (*pb.LogicalBridge, error) { | ||
| // Create executes the creation of the LogicalBridge |
There was a problem hiding this comment.
if this function operates on models now, where in the code we no return grpc response ?
There was a problem hiding this comment.
Good point @glimchb. I've pulled back the abstraction to focus on consolidating how the operations are performed on the store. At the boundaries of each pb operation proto bufs are used, but the internal workings of those functions are consolidated to a set of object store operations defined in objects/object.go
Signed-off-by: Brian Rochford <[email protected]>
glimchb
added a commit
to glimchb/opi-evpn-bridge
that referenced
this pull request
Oct 24, 2023
inspired by opiproject#279 Signed-off-by: Boris Glimcher <[email protected]>
glimchb
added a commit
that referenced
this pull request
Oct 24, 2023
inspired by #279 Signed-off-by: Boris Glimcher <[email protected]>
|
Let me know your thoughts on this approach @glimchb. Waiting on your feedback before proceeding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just updates for the bridge object for now. Still more work to do, but some idea on the approach.