Skip to content

Commit

Permalink
fix(deps): depricate parent tests for api changes
Browse files Browse the repository at this point in the history
Signed-off-by: Mark Sanders <[email protected]>
  • Loading branch information
sandersms authored and artek-koltun committed Jan 23, 2024
1 parent 83f8ca2 commit c3bb9cc
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 18 deletions.
19 changes: 10 additions & 9 deletions pkg/backend/aio_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -479,15 +479,16 @@ func TestBackEnd_ListAioVolumes(t *testing.T) {
size: 1,
token: "existing-pagination-token",
},
"no required field": {
in: "",
out: []*pb.AioVolume{},
spdk: []string{},
errCode: codes.Unknown,
errMsg: "missing required field: parent",
size: 0,
token: "",
},
// Parent field not in message - depricate test
// "no required field": {
// in: "",
// out: []*pb.AioVolume{},
// spdk: []string{},
// errCode: codes.Unknown,
// errMsg: "missing required field: parent",
// size: 0,
// token: "",
// },
}

// run tests
Expand Down
19 changes: 10 additions & 9 deletions pkg/frontend/blk_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -426,15 +426,16 @@ func TestFrontEnd_ListVirtioBlks(t *testing.T) {
1,
"existing-pagination-token",
},
"no required field": {
"",
[]*pb.VirtioBlk{},
[]string{},
codes.Unknown,
"missing required field: parent",
0,
"",
},
// Parent field not in message - depricate test
// "no required field": {
// "",
// []*pb.VirtioBlk{},
// []string{},
// codes.Unknown,
// "missing required field: parent",
// 0,
// "",
// },
}

// run tests
Expand Down

0 comments on commit c3bb9cc

Please sign in to comment.