Value of beatmap.difficulty does not match documentation
#70
Labels
bug
Something isn't working
Comments
opl-
added a commit
that referenced
this issue
Sep 7, 2021
Changes: - Support for Beat Saber v1.17.0 (#73, by @ErisApps) - `beatmap.difficulty` now represents the name of the difficulty in the game's current language. If SongCore is installed, this value may contain the custom difficulty name defined by the beatmap, however I've not actually seen that happen. (#70) - The mod now targets .NET v4.7.2 Fixes: - Exception thrown when SongCore is not installed while extracting value for `beatmap.songHash`. (#69, by @rynan4818)
opl-
added a commit
that referenced
this issue
Sep 7, 2021
Changes: - Support for Beat Saber v1.17.0 (#73, by @ErisApps) - `beatmap.difficulty` now represents the name of the difficulty in the game's current language. If SongCore is installed, this value may contain the custom difficulty name defined by the beatmap, however I've not actually seen that happen. (#70) - The mod now targets .NET v4.7.2 Adds: - `beatmap.difficultyEnum` representing the internal beatmap difficulty enum. See [protocol.md] for more information. Fixes: - Exception thrown when SongCore is not installed while extracting value for `beatmap.songHash`. (#69, by @rynan4818)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As noted in #68, the
beatmap.difficultyproperty stores the localized difficulty name instead of the intended name of theBeatmapDifficultyenum's value.I believe the best fix here would be to introduce a new property in the
beatmapobject which would expose the intended string and update the documentation accordingly. Additionally, the existingbeatmap.difficultyproperty can later be used to expose the custom difficulty name set by a mapper, to match the name visible in the beatmap selection menu.The text was updated successfully, but these errors were encountered: